feat(review-reminders): edge to edge support by david-allison · Pull Request #21582 · ankidroid/Anki-Android

david-allison · 2026-08-23T22:01:32Z

Note

Assisted-by: Claude Fable 5

Purpose / Description

ScheduleRemindersFragment and ReminderTroubleshootingFragment needed edge to edge support

Fixes

Approach

Before starting, consume the insets which will be passed to the fragments, then set the insets on a per-element basis.

There was lots of experimentation here to get the screenshots working correctly (ensuring the toolbars extended into the cutouts, ensuring scrolling), each is split into a separate commit.

I have a follow-up implemented for 'Settings', but this PR is already too large:

E2e 2 fragments david-allison/Anki-Android#67

How Has This Been Tested?

Screenshot tests are added.

API 37

----

Learning

FragmentHost made this difficult

Checklist

You have a descriptive commit message with a short title (first line, max 50 chars).
You have commented your code, particularly in hard-to-understand areas
You have performed a self-review of your own code
UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
UI Changes: You have tested your change using the Google Accessibility Scanner

github-actions · 2026-08-23T22:09:39Z

Snapshot diff report vs main. Open screenshot-diff for diffs.

ReviewRemindersScreenshotTest: 6 changes

All 6 changed screenshots

ReviewRemindersScreenshotTest

settingsHostTablet_troubleshooting_compare.png
settingsHost_landscapeCutout_collapsed_compare.png
settingsHost_landscapeCutout_compare.png
settingsHost_landscapeCutout_rtl_compare.png
standaloneActivityHost_systemBars_compare.png
standaloneActivityHost_systemBars_scrolledToEnd_compare.png

david-allison · 2026-08-26T21:51:31Z

Investigating:

Fixed

Snackbar should use the inset.

EDIT: This is screenshot-only

settingsHost_landscapeCutout_collapsed_compare

Bad alignment of the text and the back arrow

standaloneActivityHost_troubleshooting_systemBars_compare

@ericli3690 I feel this one is better

settingsHostTablet_troubleshooting_compare

ericli3690 · 2026-08-27T22:55:58Z

@david-allison Regarding the screenshot comparison you've annotated with "I feel this one is better": I do agree the padding change looks fine. I'm curious though if it's inconsistent with the title padding on the other Settings screens (ex. Reviewing, General). In particular, does the title padding noticeably change when transitioning from the Schedule Reminders page to the Troubleshooting page? If not then LGTM on that front

Will do a full review of this PR starting now

Edit: unit tests failing with legitimate failure

david-allison · 2026-08-27T23:05:11Z

Fixed, sorry!

ericli3690

LGTM!! Thanks for taking this on, really appreciate it. Tested on my phone and tablet and it looks good. Ping me on the Settings / Preferences + SingleFragmentActivity e2e migrations when they're ready and I'll take a look at those too, thanks thanks

david-allison · 2026-08-28T08:15:31Z

Cheers! I don't want to mark this as awaiting my reply, but I'd like to get to these nitpicks before merge

The fragments now unconditionally fit the system windows: the host activities consume the insets. Issue 17334 Part of 21519 Assisted-by: Claude Fable 5

Part of 17334 Part of 21519 Assisted-by: Claude Fable 5

* Removes the black bar in landscape mode * Troubleshooting content renders underneath the bottom bar Part of 17334 Part of 21519 Assisted-by: Claude Fable 5

The content of the toolbar in landscape mode of a phone overlapped with the display cutout. Part of 17334 Assisted-by: Claude Fable 5

The decor consumed the navigation bar inset, so scrolled content did not render underneath the nav bar. Part of 17334 Fixes 21519 Assisted-by: Claude Fable 5

BaseTransientBottomBar uses the deprecated `systemWindowInsets` accessors which include the display cutout on a real device. In tests, we manually add the cutout to the navigationBars() to simulate this Part of 17334 Part of 21519 Assisted-by: Claude Fable 5

david-allison · 2026-08-28T18:42:03Z

@ericli3690 handled, re-review if you wish

ericli3690

Yep, looks awesome to me! Thanks thanks again

david-allison requested a review from ericli3690 August 23, 2026 22:01

github-actions Bot added the Needs Review label Aug 23, 2026

david-allison added the Needs Author Reply Waiting for a reply from the original author label Aug 23, 2026

This comment was marked as resolved.

Sign in to view

david-allison force-pushed the edge-to-edge-schedule-reminders-cleanup branch 2 times, most recently from e0780d1 to b42c9cf Compare August 24, 2026 00:34

david-allison added Blocked by dependency Currently blocked by some other dependent / related change and removed Needs Author Reply Waiting for a reply from the original author labels Aug 24, 2026

david-allison mentioned this pull request Aug 24, 2026

feat(review-reminders): prep for edge to edge #21588

Merged

5 tasks

david-allison marked this pull request as draft August 24, 2026 00:36

david-allison added Needs Author Reply Waiting for a reply from the original author and removed Blocked by dependency Currently blocked by some other dependent / related change labels Aug 26, 2026

github-actions Bot added the Has Conflicts label Aug 26, 2026

david-allison force-pushed the edge-to-edge-schedule-reminders-cleanup branch from b42c9cf to 74918b8 Compare August 26, 2026 21:29

github-actions Bot removed the Has Conflicts label Aug 26, 2026

david-allison added Review High Priority Request for high priority review and removed Needs Author Reply Waiting for a reply from the original author labels Aug 26, 2026

david-allison marked this pull request as ready for review August 26, 2026 21:48

david-allison force-pushed the edge-to-edge-schedule-reminders-cleanup branch from 072d90b to f3e14a0 Compare August 26, 2026 23:37

david-allison force-pushed the edge-to-edge-schedule-reminders-cleanup branch from f3e14a0 to 010e7e7 Compare August 27, 2026 23:05

ericli3690 approved these changes Aug 28, 2026

View reviewed changes

ericli3690 added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 28, 2026

david-allison added 2 commits August 28, 2026 19:25

refactor(review-reminders): remove FragmentHost.supportsEdgeToEdge

45e4791

The fragments now unconditionally fit the system windows: the host activities consume the insets. Issue 17334 Part of 21519 Assisted-by: Claude Fable 5

fix(review-reminders): edge to edge: move content away from cutouts

9fab918

Part of 17334 Part of 21519 Assisted-by: Claude Fable 5

david-allison added 4 commits August 28, 2026 19:26

fix(review-reminders): edge to edge: render under the insets

a5c88f4

* Removes the black bar in landscape mode * Troubleshooting content renders underneath the bottom bar Part of 17334 Part of 21519 Assisted-by: Claude Fable 5

fix(review-reminders): handle display cutout (landscape mode)

7b86528

The content of the toolbar in landscape mode of a phone overlapped with the display cutout. Part of 17334 Assisted-by: Claude Fable 5

fix(review-reminders): tablet: render underneath the bottom bar

bf07da3

The decor consumed the navigation bar inset, so scrolled content did not render underneath the nav bar. Part of 17334 Fixes 21519 Assisted-by: Claude Fable 5

david-allison force-pushed the edge-to-edge-schedule-reminders-cleanup branch from 010e7e7 to 79c9309 Compare August 28, 2026 18:31

ericli3690 approved these changes Aug 29, 2026

View reviewed changes

david-allison added this pull request to the merge queue Aug 30, 2026

Merged via the queue into ankidroid:main with commit 8481688 Aug 30, 2026
21 checks passed

github-actions Bot added this to the 2.25 release milestone Aug 30, 2026

github-actions Bot removed Review High Priority Request for high priority review Needs Second Approval Has one approval, one more approval to merge labels Aug 30, 2026

Navigation Menu

Uh oh!

Uh oh!

feat(review-reminders): edge to edge support - #21582

feat(review-reminders): edge to edge support#21582
david-allison merged 6 commits into
ankidroid:mainfrom
david-allison:edge-to-edge-schedule-reminders-cleanup

david-allison commented Aug 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

david-allison commented Aug 26, 2026 •

edited

Loading

Uh oh!

ericli3690 commented Aug 27, 2026 •

edited

Loading

Uh oh!

david-allison commented Aug 27, 2026

Uh oh!

ericli3690 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-allison commented Aug 28, 2026

Uh oh!

david-allison commented Aug 28, 2026

Uh oh!

ericli3690 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

david-allison commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose / Description

Fixes

Approach

How Has This Been Tested?

Learning

Checklist

Uh oh!

github-actions Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

david-allison commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ericli3690 commented Aug 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

david-allison commented Aug 27, 2026

Uh oh!

ericli3690 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

david-allison commented Aug 28, 2026

Uh oh!

david-allison commented Aug 28, 2026

Uh oh!

ericli3690 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

david-allison commented Aug 23, 2026 •

edited

Loading

github-actions Bot commented Aug 23, 2026 •

edited

Loading

david-allison commented Aug 26, 2026 •

edited

Loading

ericli3690 commented Aug 27, 2026 •

edited

Loading